[Draft] feat: Initial codecov endpoint for fetching test results #91911
Conversation
github-actions
bot
added
the
Scope: Backend
❌ 2 Tests Failed:
View the top 2 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
…er we add codecovClient convenience func
| after: $after | ||
| last: $last | ||
| before: $before | ||
| ) { |
There was a problem hiding this comment.
We should also return the after and last as part of this query right?
There was a problem hiding this comment.
Return in the response or?
| """ | ||
|
|
||
|
|
||
| class TestResultNodeSerializer(serializers.Serializer): |
There was a problem hiding this comment.
Are we adding all singular serializers the word node? You used it here to differentiate from the list, but would that lead to other singular resources having the word node too?
There was a problem hiding this comment.
I think we would for any responses that return edge nodes. We have quite a few that do
There was a problem hiding this comment.
For any "list" endpoints I think the word Node makes a lot of sense since that's what the GQL response would be returning.
For single items though I don't think we'd need the word node since that wouldn't be an object returned in the GQL response, if that makes sense
| variables = { | ||
| "owner": owner, | ||
| "repo": repository, | ||
| "commit": commit, |
There was a problem hiding this comment.
We don't seem to be using this variable in the query.
Also we are missing the filters, ordering and pagination vars as well right?
There was a problem hiding this comment.
Yeah haha, I wasn't planning to hook everything up initially just so we could get a mock response returned to the frontend first and then work on this in tandem. But since we've merged the query convenience function now maybe I can cook
This PR is currently a draft.
This PR aims to create our first codecov (mocked) endpoint for test results, a "get" endpoint that calls the codecov client with different graphql queries depending on the request url.
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.